Conversation
|
Posting some load testing results using local Postgres: Output: Note that this is much faster compare to existing implementation (#555) which takes 1.5 SECONDS to prepare 1000 messages for sending. Source code: |
|
@Yu-Xie if you would change |
Makes sense -- I have addressed these feedbacks in #599 |
| for _, mb := range msgBytes { | ||
| s.toSend = append(s.toSend, mb) | ||
| select { | ||
| case s.messageEvent <- true: |
There was a problem hiding this comment.
this can be moved out of the loop as we don't release the lock until we return so it is not very useful to notify each time
Prototype for #555
func SaveMessagesAndIncrNextSenderMsgSeqNum(seqNum int, msg [][]byte)in the storage interface, and then afunc SendAppToTarget(m []Messagable, sessionID SessionID) errorinregistry.goto expose it.